Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes methods and properties from private to protected #2308

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

luceos
Copy link
Member

@luceos luceos commented Sep 24, 2020

Changes proposed in this pull request:

The goal of this PR is to offer increased flexibility for integrators and
custom solutions in skeleton modifications.

The goal of this PR is to offer increased flexibility for integrators and
custom solutions in skeleton modifications.
@luceos
Copy link
Member Author

luceos commented Sep 24, 2020

That was fast 🙈

@tankerkiller125
Copy link
Contributor

@luceos I watch Github like a hawk these days for minor improvements I can approve easily. I'm working on those review chops.

@askvortsov1 askvortsov1 merged commit aea8a3f into master Sep 24, 2020
@askvortsov1 askvortsov1 deleted the dk/visibility branch September 24, 2020 18:30
@askvortsov1 askvortsov1 added this to the 0.1.0-beta.14 milestone Sep 24, 2020
@franzliedke
Copy link
Contributor

Hey, these interfaces are small. And most of these classes could be considered internal. But hey. 😉

@franzliedke
Copy link
Contributor

franzliedke commented Sep 25, 2020

For example, #2271 will remove at least one of those methods, which may also break your overrides unexpectedly. All I'm saying is you will have to watch this space for changes anyway, and I don't consider these internals to be part of the API that's protected (get it?) from BC breaks.

@luceos
Copy link
Member Author

luceos commented Sep 26, 2020

I do get it. We talked about this before. Someone who overrides those classes does so at their own risk and expertise. Not providing this ability seriously hampers extensibility and forces someone to fully copy complete classes or sometimes multiple. That shouldn't be our goal.

The idea of the skeleton is that one can create their own fairly simple. Using private on all classes that the skeleton uses seriously hampers the flexibility we supposedly provide. Thats all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants