Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve developer experience by forcing LF line endings #2321

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

w-4
Copy link
Contributor

@w-4 w-4 commented Sep 28, 2020

Changes proposed in this pull request:
Force LF line endings when checking out files. The default on git for windows is to checkout with CRLF line endings and to commit with LF line endings. Because of the husky prettier hook, after each commit it reformats all files, showing up as changes.

Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! Although I suppose we'd probably want an ending newline. That's about as minor a nitpick as possible though :D

@askvortsov1 askvortsov1 changed the title Improve developer experience Improve developer experience by forcing LF line endings Sep 28, 2020
@askvortsov1 askvortsov1 merged commit d6511e0 into flarum:master Sep 28, 2020
@askvortsov1 askvortsov1 added this to the 0.1.0-beta.14 milestone Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants