Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right align discussion controls dropdown button on slidable item #2330

Merged
merged 1 commit into from
Sep 30, 2020
Merged

Right align discussion controls dropdown button on slidable item #2330

merged 1 commit into from
Sep 30, 2020

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Sep 30, 2020

Fixes #2329

Confirmed

  • Frontend changes: tested on a local Flarum installation.

askvortsov1
askvortsov1 approved these changes Sep 30, 2020
View reviewed changes
Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks for finding (and fixing!) this!

@askvortsov1 askvortsov1 merged commit 6d826e5 into flarum:master Sep 30, 2020
@SychO9 SychO9 deleted the sm/fix-slidable-underneath-controls branch September 30, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tankerkiller125 tankerkiller125 tankerkiller125 approved these changes

@clarkwinkelmann clarkwinkelmann clarkwinkelmann approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

@dsevillamartin dsevillamartin Awaiting requested review from dsevillamartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mobile] Slidable underneath discussion controls alignment
4 participants
@SychO9 @tankerkiller125 @clarkwinkelmann @askvortsov1