Fix Callables for Extenders #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
requested review from
clarkwinkelmann,
tankerkiller125 and
luceos
2 tasks
… an invokable class.
…ocessor extenders accept callbacks
[ci skip] [skip ci]
askvortsov1
force-pushed
the
as/fix-callables-extenders
branch
from
4d3e137
to
104fbe3
Compare
[ci skip] [skip ci]
SychO9
reviewed
Nov 5, 2020
Comment on lines
+17
to
+21
| $callback = function () use ($container, $callback) { | ||
| $callback = $container->make($callback); | ||
|
|
||
| return call_user_func_array($callback, func_get_args()); | ||
| }; |
There was a problem hiding this comment.
why not just $callback = $container->make($callback); ?
There was a problem hiding this comment.
Clark pointed out in #2176 (comment) that $callback = $container->make($callback); means that the callback will be resolved every time the site boots, even if its not needed for that request.
There was a problem hiding this comment.
I do agree it's a bit ugly, if there are simpler ways to do it, I'm all ears. But at least with the util, it's abstracted away so if we need to change it, that should be easy.
clarkwinkelmann
requested changes
Nov 6, 2020
|
@clarkwinkelmann fixed! Any thoughts on naming for the util? |
SychO9
reviewed
Nov 6, 2020
luceos
approved these changes
Nov 7, 2020
clarkwinkelmann
approved these changes
Nov 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2401, mostly minor cleanup and adding tests to prevent regressions.