Improved Permissions Error Messages for Initial Install #2435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Made the wording of the error more generic - Added link to the relevant section in the installation guide Resolves #2327.
|
@askvortsov1, thanks for merging the related pull request with the update to the installation docs. This one makes the error message more generic and adds a link to the docs, could you please review? |
askvortsov1
requested changes
Nov 6, 2020
| @@ -53,7 +53,7 @@ private function getNonWritablePaths(): Collection | |||
| })->map(function ($path, $index) { | |||
| return [ | |||
| 'message' => 'The '.$this->getAbsolutePath($path).' directory is not writable.', | |||
| 'detail' => 'Please chmod this directory'.(in_array($index, $this->wildcards) ? ' and its contents' : '').' to 0775.' | |||
| 'detail' => 'Please make sure your web server/PHP user has write access to this directory'.(in_array($index, $this->wildcards) ? ' and its contents' : '').'. Please read the <a href="https://docs.flarum.org/install.html#folder-ownership">installation documentation</a> for a detailed explanation and steps to follow to resolve this error.' | |||
There was a problem hiding this comment.
Minor wording critiques:
- Both sentences start with please, that's a bit much imo, we can probably remove that from the second sentence.
- "steps to follow to resolve this error" => "steps to resolve this error"
There was a problem hiding this comment.
Updated with both changes - looks better now.
askvortsov1
approved these changes
Nov 7, 2020
SychO9
approved these changes
Nov 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2327
Changes proposed in this pull request:
The "Hold up!" page during the installation process.
Reviewers should focus on:
The wording of the message.
Screenshot
Confirmed
composer test).Required changes: