Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 support #2507

Merged
merged 29 commits into from
Jan 26, 2021
Merged

PHP 8 support #2507

merged 29 commits into from
Jan 26, 2021

Conversation

luceos
Copy link
Member

@luceos luceos commented Dec 22, 2020

fixes #2439

Attempts to offer support for php 8, so far:

@franzliedke
Copy link
Contributor

franzl/whoops-middleware now supports everything from PHP 7.2 through PHP 8.0 with the new 2.0 release. Please use that. 😃

@luceos
Copy link
Member Author

luceos commented Jan 4, 2021

@franzliedke thank you, I was hoping for that 🤗

@luceos luceos marked this pull request as ready for review January 13, 2021 20:31
Copy link
Contributor

@tankerkiller125 tankerkiller125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the main showstopper was the cookie library originally, this looks good I see no issues with the cookie lib replacement and CI test are passing. (I have no tested locally yet)

composer.json Outdated Show resolved Hide resolved
src/Http/CookieFactory.php Outdated Show resolved Hide resolved
src/Http/CookieFactory.php Outdated Show resolved Hide resolved
src/Http/CookieFactory.php Outdated Show resolved Hide resolved
src/Http/Rememberer.php Outdated Show resolved Hide resolved
caret already allows for higher versions
@askvortsov1 askvortsov1 mentioned this pull request Jan 26, 2021
@askvortsov1 askvortsov1 linked an issue Jan 26, 2021 that may be closed by this pull request
[ci skip] [skip ci]
Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like our current library was updated: https://packagist.org/packages/dflydev/fig-cookies

In the spirit of minimal changes, I'd say we should stick with that, although keep the new tests (and include a test case for calling ->expires())

Sorry for all the back and forth on this one

tests/unit/Http/CookieFactoryTest.php Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
src/Http/CookieFactory.php Show resolved Hide resolved
tests/integration/BuildsHttpRequests.php Outdated Show resolved Hide resolved
tests/unit/Foundation/ContainerUtilTest.php Show resolved Hide resolved
tests/unit/Http/CookieFactoryTest.php Show resolved Hide resolved
@askvortsov1 askvortsov1 merged commit 65b5c20 into master Jan 26, 2021
@askvortsov1 askvortsov1 deleted the dk/php-8 branch January 26, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP 8 Support Consider switching cookie library
5 participants