Convert highlight helper to Typescript

[daniellesniak]

See #3533

[dsevillamartin]

Should the types be removed from the jsdoc comment? 🤔

I feel like there's no reason to have them there twice. The JSDoc is still helpful for the description of the arguments.

[daniellesniak]

You're right, I fixed that.

Edit/:
I misunderstood your guidelines and removed all types' descriptions from JSDoc in previous commit so I fixed my mistake in next one. It should be fine now.

[w-4]

also: .tsx file extension

[daniellesniak]

I made length parameter optional, everything else look fine to me.

[askvortsov1]

Makes sense to me, thanks!

[dsevillamartin]

I wonder - does m.trust() only return a Mithril.Vnode? I am unable to check right now.

[daniellesniak]

It's written in documentation that m.trust() returns Vnode. The same return type is in interface.

Docs:

Interface:

Should I change return type to Mithril.Vnode<any, any> as in interface instead of Mithril.Vnode?

[dsevillamartin]

Should I change return type to Mithril.Vnode<any, any> as in interface instead of Mithril.Vnode?

I think so, yeah.

[dsevillamartin]

LGTM!