Add user badges to post preview #1765 #2555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebasing on origin/master should fix the failing tests |
|
Thanks! Done |
|
Looks like some unrelated commits got in, perhaps you might have pushed instead of force pushed? |
imorland
force-pushed
the
im/postpreview
branch
from
03a4b84
to
019789c
Compare
|
Whoops |
|
Would we want to include the full PostUser composer, so the user card shows up on hover? |
|
I did look at that. As things stand, the full |
|
Fair, another argument against PostUser would be that there's not that big a need for the current user to see more information about themselves. |
askvortsov1
requested changes
Jan 20, 2021
askvortsov1
approved these changes
Jan 20, 2021
SychO9
approved these changes
Feb 10, 2021
KyrneDev
pushed a commit
that referenced
this pull request
Feb 20, 2021
askvortsov1
pushed a commit
that referenced
this pull request
Feb 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Fixes flarum/issue-archive#248 **
Changes proposed in this pull request:
Reviewers should focus on:
For consistency, the user badges are added to the post preview, so that it cosmetically fits with the rest of the post stream
Screenshot
Confirmed
composer test).