Laravel components v8

[luceos]

**Fixes #2538 **

Still needs to be tested inside the skeleton.

Confirmed

• Frontend changes: tested on a local Flarum installation.
• Backend changes: tests are green (run composer test).

Required changes:

• Related documentation PR: (Remove if irrelevant)
• Related core extension PRs: (Remove if irrelevant)

Companion PRs

• made compatible with illuminate 8 and beta 16 tags#121

[askvortsov1]

On the Laravel upgrade guide, a dependence on Symfony 5 is listed as one of the high impact changes, but we don't seem to have changed our symfony version at all: https://laravel.com/docs/7.x/upgrade#symfony-5-related-upgrades. Symfony 5 seems to be implicitly required for console though. Are there downsides to having separate versions of symfony for different symfony components?

It seems like the most impactful change would be the deprecation of the Translator interface that's used commonly in extensions.

[luceos]

On the Laravel upgrade guide, a dependence on Symfony 5 is listed as one of the high impact changes, but we don't seem to have changed our symfony version at all: https://laravel.com/docs/7.x/upgrade#symfony-5-related-upgrades. Symfony 5 seems to be implicitly required for console though. Are there downsides to having separate versions of symfony for different symfony components?

It seems like the most impactful change would be the deprecation of the Translator interface that's used commonly in extensions.

I still need to go over testing inside the skeleton as mentioned in OP. I bet there are a ton of other issues to fix before this all works ;)

[askvortsov1]

@luceos I tested this with a skeleton install, and made the above 2 commits, which mitigate most issues with extensions that use the translator.

Aside from that, there are a few issues we won't be able to compensate for:

• Extensions requiring fof/console will break, as that depends on illuminate/console v6, which depends on symfony console v4, which conflicts with core's use of symfony console v5.
• The signature of setKeysForSaveQuery on line 65 of TagState in tags needs the typehint removed to comply with Laravel's interface / abstract class.

Other than that, I haven't found issues in the things I tried.

[askvortsov1]

Found one very minor formatting issue in composer.json

[askvortsov1]

Looks like there's a few more phpunit related changes needed to the tests before this can be merged

[tankerkiller125]

Now that the test are good I'm happy with this