Rename ApiSerializer's mutate to attributes #2578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
requested changes
Jan 27, 2021
SychO9
force-pushed
the
sm/apiserializer-extender-mutate-to-attributes
branch
from
1bb0845
to
f6a8c37
Compare
SychO9
commented
Jan 30, 2021
askvortsov1
requested changes
Feb 4, 2021
SychO9
force-pushed
the
sm/apiserializer-extender-mutate-to-attributes
branch
from
c39edea
to
247f89e
Compare
askvortsov1
approved these changes
Feb 4, 2021
tankerkiller125
approved these changes
Feb 5, 2021
askvortsov1
requested changes
Feb 5, 2021
| @@ -67,13 +67,35 @@ public function attribute(string $name, $callback) | |||
| * | |||
| * @return self | |||
| */ | |||
| public function mutate($callback) | |||
| public function attributes($callback) | |||
There was a problem hiding this comment.
I just realized, we need to deprecate the mutate method, since that was released in the previous version
There was a problem hiding this comment.
it is deprecated, look below this code
There was a problem hiding this comment.
I.... don't know how I missed that... What.... 🙈
askvortsov1
approved these changes
Feb 5, 2021
| @@ -67,13 +67,35 @@ public function attribute(string $name, $callback) | |||
| * | |||
| * @return self | |||
| */ | |||
| public function mutate($callback) | |||
| public function attributes($callback) | |||
There was a problem hiding this comment.
I.... don't know how I missed that... What.... 🙈
askvortsov1
deleted the
sm/apiserializer-extender-mutate-to-attributes
branch
KyrneDev
pushed a commit
that referenced
this pull request
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1891
Confirmed
composer test).Required changes: