[A11Y] Add aria-label and landmark role to search input #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davwheat
changed the title
davwheat
added
the
type/accessibility
davwheat
changed the title
askvortsov1
reviewed
Mar 16, 2021
askvortsov1
requested changes
Mar 16, 2021
askvortsov1
approved these changes
Mar 16, 2021
SychO9
approved these changes
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2667
Changes proposed in this pull request:
Adds the
aria-labelattribute to the search input.Also adds
role="search"to the containing div. See this page for more info.For info about why this is required, see the related issue (#2667).
Screenshot
Confirmed