Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace classList with clsx library #2760

Merged
merged 1 commit into from
Apr 5, 2021
Merged

Replace classList with clsx library #2760

merged 1 commit into from
Apr 5, 2021

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Apr 5, 2021

Progresses flarum/issue-archive#179

Changes proposed in this pull request:
Replaces our own classList with an export of clsx.

I couldn't see where we actually used classnames anywhere -- did we replace them all with our own classList and forget to remove the dep?

Confirmed

  • Frontend changes: tested on a local Flarum installation.

@davwheat davwheat added type/cleanup dependencies Pull requests that update a dependency file labels Apr 5, 2021
@davwheat davwheat self-assigned this Apr 5, 2021
@dsevillamartin
Copy link
Member

I couldn't see where we actually used classnames anywhere

We never used the classnames library. It was added during the beta 14 dev process and we never actually ended up using (my mithril branch did use it)

@davwheat davwheat merged commit 4b69a35 into master Apr 5, 2021
@davwheat davwheat deleted the dw/2345-use-clsx branch April 5, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tankerkiller125 tankerkiller125 tankerkiller125 approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

@dsevillamartin dsevillamartin Awaiting requested review from dsevillamartin

Assignees

@davwheat davwheat

Labels
dependencies Pull requests that update a dependency file type/cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davwheat @dsevillamartin @tankerkiller125 @askvortsov1