Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded vendor prefixes #2766

Merged
merged 2 commits into from
Apr 7, 2021
Merged

Remove unneeded vendor prefixes #2766

merged 2 commits into from
Apr 7, 2021

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Apr 5, 2021

Fixes #2762

Changes proposed in this pull request:

  • Removes pointless vendor prefixes that do nothing as we don't support the browsers that they provide support for.
  • I've also bundled in a fix for the post scrubber where it wasn't using the -webkit- prefix for user-select

Confirmed

  • Frontend changes: tested on a local Flarum installation.

@davwheat davwheat self-assigned this Apr 5, 2021
askvortsov1
askvortsov1 approved these changes Apr 5, 2021
View reviewed changes
Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, but changes make sense. When merged, this should be merged via merge commit, since changes are granular. 👍

SychO9
SychO9 approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏼 I hadn't even noticed these before.

@davwheat davwheat merged commit 69a10c9 into master Apr 7, 2021
@davwheat davwheat deleted the dw/2762-remove-vendor-prefixes branch April 7, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees

@davwheat davwheat

Labels
type/cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unneeded vendor Less mixins
3 participants
@davwheat @SychO9 @askvortsov1