Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user id slug driver #2787

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Add user id slug driver #2787

merged 1 commit into from
Apr 20, 2021

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Apr 16, 2021

Part of flarum/issue-archive#254

Changes proposed in this pull request:
Adds an id slug driver for the user model.

Reviewers should focus on:
Code quality.

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

@SychO9 SychO9 merged commit b62debf into master Apr 20, 2021
@SychO9 SychO9 deleted the sm/1734-user-id-slugger branch April 20, 2021 22:52
@askvortsov1 askvortsov1 added this to the 1.0 milestone Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tankerkiller125 tankerkiller125 tankerkiller125 approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SychO9 @tankerkiller125 @askvortsov1