Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve discussion page canonical URL #2853

Merged
merged 6 commits into from
May 10, 2021

Conversation

dsevillamartin
Copy link
Member

Fixes #2397
Fixes #2130

Changes proposed in this pull request:

  • Switch to ?page= parameter for canonical URL
  • Fix no-JS pagination

Reviewers should focus on:
I don't like any of this no-JS code.

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

  • Related core extension PRs: (Remove if irrelevant)

@askvortsov1 askvortsov1 force-pushed the ds/2397-improve-discussion-page-canonical-url branch from 2bb9b0e to 09c0543 Compare May 10, 2021 22:36
[ci skip] [skip ci]
@askvortsov1 askvortsov1 merged commit 765bd59 into master May 10, 2021
@askvortsov1 askvortsov1 deleted the ds/2397-improve-discussion-page-canonical-url branch May 10, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants