Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use display name for avatar color gen #2873

Merged
merged 1 commit into from
Jun 21, 2021
Merged

use display name for avatar color gen #2873

merged 1 commit into from
Jun 21, 2021

Conversation

ctml91
Copy link
Contributor

@ctml91 ctml91 commented May 17, 2021 •
edited
Loading

Fixes #2690

Changes proposed in this pull request:
Generate avatar colours based on display name, rather than username

Confirmed

  • Frontend changes: tested on a local Flarum installation.

Required changes:

None

askvortsov1
askvortsov1 approved these changes May 20, 2021
View reviewed changes
Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you! We'll need to wait until the next release to merge this though, as we're currently in feature freeze.

@SychO9 SychO9 self-requested a review June 5, 2021 18:34
@luceos luceos merged commit 3fcc7bd into flarum:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tankerkiller125 tankerkiller125 tankerkiller125 approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

@SychO9 SychO9 Awaiting requested review from SychO9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate user colour from configured display driver
4 participants
@ctml91 @tankerkiller125 @askvortsov1 @luceos