make user.editGroups depending on viewHiddenGroups #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should resolve #2610
SychO9
approved these changes
Aug 10, 2021
davwheat
approved these changes
Aug 10, 2021
|
Wouldn't it have been more logical to make the backend responsible for looping over the groups that are not visible and locking them, while updating those that are visible and have been changed? Because now we require a permission for another permission to work. I can imagine situations where groups can be hidden (like authorative users) but mods should still be allowed to upgrade simple member groups. @jordanjay29 a penny for your thoughts. |
|
@luceos the plan was to go with https://github.com/flarum/core/issues/2610#issuecomment-840677323 and have this done temporarily. though I don't have any strong opinions on this, feel free to re-open the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flarum/issue-archive#149
Changes proposed in this pull request:
make user.editGroups depending on viewHiddenGroups
Reviewers should focus on:
is it that simple?
Confirmed