Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert extend util to TypeScript #2928

Merged
merged 18 commits into from
Nov 8, 2021
Merged

Convert extend util to TypeScript #2928

merged 18 commits into from
Nov 8, 2021

Commits on Oct 30, 2021

  1. WIP

    @dsevillamartin
    dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    6f21fcf View commit details
    Browse the repository at this point in the history

  2. WIP

    @dsevillamartin
    dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    ea4f2ac View commit details
    Browse the repository at this point in the history

  3. Move ExtendCallback straight to function declaration

    @dsevillamartin
    dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    cc3d56f View commit details
    Browse the repository at this point in the history

  4. Allow using file extension in core compat imports 

    Necessary for extend imports to have proper typings as we also have an unrelated extend/index.js file
    @dsevillamartin
    dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    e59c217 View commit details
    Browse the repository at this point in the history

  5. Add .ts file extension to extend imports for typings

    @dsevillamartin
    dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    8597ec0 View commit details
    Browse the repository at this point in the history

  6. Use Parameters<T[K]> for callback args

    @dsevillamartin
    dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    e4b0dd4 View commit details
    Browse the repository at this point in the history

  7. Fix issues with RegExp

    @dsevillamartin
    dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    975fc36 View commit details
    Browse the repository at this point in the history

  8. Fix changes to proxifyCompat regex breaking non-core import paths

    @dsevillamartin
    dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    ac1c7a6 View commit details
    Browse the repository at this point in the history

  9. Change <T[K]> to 'as T[K]' and use Parameters<T[K]> when setting obje… 

    …ct[method]
    @dsevillamartin
    dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    392c0ac View commit details
    Browse the repository at this point in the history

  10. Don't use lookbehind (unsupported on Safari iOS)

    @dsevillamartin
    dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    67ce00e View commit details
    Browse the repository at this point in the history

  11. Add missing typings for this

    @davwheat @dsevillamartin
    davwheat authored and dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    abfa463 View commit details
    Browse the repository at this point in the history

  12. Move utility types to global types

    @davwheat @dsevillamartin
    davwheat authored and dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    b417889 View commit details
    Browse the repository at this point in the history

  13. Remove type from source

    @davwheat @dsevillamartin
    davwheat authored and dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    3045958 View commit details
    Browse the repository at this point in the history

  14. Reformat

    @davwheat @dsevillamartin
    davwheat authored and dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    16566db View commit details
    Browse the repository at this point in the history

  15. Format

    @davwheat @dsevillamartin
    davwheat authored and dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    ba79c55 View commit details
    Browse the repository at this point in the history

  16. Follow standard export pattern

    @davwheat @dsevillamartin
    davwheat authored and dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    76efb98 View commit details
    Browse the repository at this point in the history

  17. Remove semicolon

    @davwheat @dsevillamartin
    davwheat authored and dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    4a50541 View commit details
    Browse the repository at this point in the history

  18. Update regex strings

    @davwheat @dsevillamartin
    davwheat authored and dsevillamartin committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    9c1fb86 View commit details
    Browse the repository at this point in the history