[1.x] Throw a validation error on ico favicons.
#2949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
askvortsov1
approved these changes
Aug 20, 2021
tankerkiller125
approved these changes
Aug 20, 2021
|
If there are no objections, I'll merge this into |
|
Go for it! Remember to cherry pick it onto master, too. |
won't be necessary, we'll just merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flarum/issue-archive#73
Changes proposed in this pull request:
As mentioned in the issue, since we can't fix the problem in an unbreaking way, we at least throw a validation error instead of a 500.
Reviewers should focus on:
Code quality.
Are there any better alternatives.
Confirmed
composer test).