Move Day.js plugin types import to global typings #2954
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2417
Changes proposed in this pull request:
Remove Day.js relativeTime plugin types import from humanTime util and add it to the global typings file.
See @davwheat's proposal on #2417.
Reviewers should focus on:
Ensuring that no error occurs when compiling the humanTime util.
Note that you'll need to pass the
--esModuleInterop
to avoid the following error (unrelated to this PR):This flag is highly recommended by the TypeScript team for both new and existing projects. I didn't add it to
tsconfig.json
because I don't understand ts enough right now to guarantee that it won't break anything :)