Use organization Prettier config #2967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Performed a manual workflow run with Prettier here: https://github.com/flarum/core/actions/runs/1043251829 Our current process doesn't install deps, so I'll need to fix that. |
|
After |
dsevillamartin
approved these changes
Jul 18, 2021
davwheat
force-pushed
the
dw/use-org-prettier
branch
from
001e25d
to
8a070cc
Compare
|
Rebased to fix PHP tests |
SychO9
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Moves our Prettier config from being handled locally in repositories to a central source of truth.
Reviewers should focus on:
Ensure formatting CI workflow runs successfully!
Required changes: