Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Custom Colorising with CSS Custom Properties #3001

Merged
merged 9 commits into from
Aug 16, 2021

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Aug 6, 2021

Fixes #2816
Progresses #2600

Changes proposed in this pull request:
This PR introduces usage of CSS variables instead if custom colors passed as inline styles, especially as a background property. The PR is not meant to convert all of the codebase to use CSS custom properties, that will take place in another PR(s), where the root CSS variables will also be properly organised.

The changes to the sideNav links and button colors are done for the tags extension's custom colorising.

This should be 100% backwards compatible and should not break any custom styling in existing communities.

Reviewers should focus on:
General code quality and anything I missed.

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

@davwheat
Copy link
Member

davwheat commented Aug 6, 2021

Thank you. Thank you! THANK YOUUUU! 🥰

js/src/common/components/Badge.js Outdated Show resolved Hide resolved
js/src/forum/components/UserCard.js Outdated Show resolved Hide resolved
SychO9 and others added 2 commits August 7, 2021 10:35
Co-authored-by: David Wheatley <hi@davwheat.dev>
Co-authored-by: David Wheatley <hi@davwheat.dev>
@SychO9 SychO9 changed the title [1.1] Custom Colorising with CSS Custom Properties [1.x] Custom Colorising with CSS Custom Properties Aug 11, 2021
@SychO9 SychO9 merged commit ef20e29 into master Aug 16, 2021
@SychO9 SychO9 deleted the sm/2816-css-variables-for-colors branch August 16, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve custom colorizing by using CSS variables
3 participants