-
-
Notifications
You must be signed in to change notification settings - Fork 826
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.x] Custom Colorising with CSS Custom Properties #3001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you. Thank you! THANK YOUUUU! 🥰 |
davwheat
reviewed
Aug 6, 2021
Co-authored-by: David Wheatley <hi@davwheat.dev>
Co-authored-by: David Wheatley <hi@davwheat.dev>
davwheat
approved these changes
Aug 9, 2021
tankerkiller125
approved these changes
Aug 9, 2021
SychO9
changed the title
[1.1] Custom Colorising with CSS Custom Properties
[1.x] Custom Colorising with CSS Custom Properties
Aug 11, 2021
This was referenced Aug 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2816
Progresses #2600
Changes proposed in this pull request:
This PR introduces usage of CSS variables instead if custom colors passed as inline styles, especially as a
background
property. The PR is not meant to convert all of the codebase to use CSS custom properties, that will take place in another PR(s), where the root CSS variables will also be properly organised.The changes to the sideNav links and button colors are done for the tags extension's custom colorising.
This should be 100% backwards compatible and should not break any custom styling in existing communities.
Reviewers should focus on:
General code quality and anything I missed.
Confirmed
Backend changes: tests are green (runcomposer test
).Required changes: