Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move email confirmation to POST request #3038

Merged
merged 2 commits into from
Aug 21, 2021
Merged

Move email confirmation to POST request #3038

merged 2 commits into from
Aug 21, 2021

Conversation

dsevillamartin
Copy link
Member

Fixes #2969

Changes proposed in this pull request:

  • Create blade view for GET request
  • Keep POST request at same URL (don't want to change to /confirm because that could be breaking if another ext uses that route)

Reviewers should focus on:

  • Do we want more blade views or to move this to JS routes?

Screenshot
image

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

askvortsov1
askvortsov1 approved these changes Aug 20, 2021
View reviewed changes
Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested locally, but code looks good

SychO9
SychO9 approved these changes Aug 21, 2021
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested locally.

@SychO9 SychO9 merged commit 57eb621 into master Aug 21, 2021
@SychO9 SychO9 deleted the ds/2969-confirm-email-with-post-req branch August 21, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

@askvortsov1 askvortsov1 askvortsov1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confirmation links are only valid once
3 participants
@dsevillamartin @SychO9 @askvortsov1