Use author filter parameter instead of q with gambit to get a user's discussions on the DiscussionsUserPage
#3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r's discussions on the `DiscussionsUserPage`
2 tasks
askvortsov1
approved these changes
Sep 8, 2021
SychO9
approved these changes
Sep 11, 2021
askvortsov1
added a commit
that referenced
this pull request
Oct 7, 2021
#3068 accidentially broke the user discussions page, as up until this commit, `DiscussionListState`didn't accept any filter params.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Changed the way the request for listing discussions on the user profile is constructed: before a gambit was used with the
qfilter parameter, now theauthorparameter is used instead. This makes it possible for extensions to use other filter parameters for this request because if theqparameter is used, all the other filter parameters are ignored.Reviewers should focus on:
Checking if
DiscussionsUserPagestill works as expected.Confirmed
composer test).