Centralize pagination/canonical meta URL generation in Document #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before merging, we'll also want to append ": Page X" on non-first-pages to the page title. |
SychO9
reviewed
Oct 28, 2021
SychO9
approved these changes
Nov 28, 2021
askvortsov1
force-pushed
the
as/pagination-content
branch
from
68859c2
to
bf84257
Compare
tankerkiller125
approved these changes
Dec 1, 2021
[ci skip] [skip ci]
|
@tankerkiller125 @SychO9 re-requesting review, as I've refactored the basic title driver to use translations for layout. Specific issues:
|
It's an implementation detail, and can be made available on specific implementations as needed.
SychO9
approved these changes
Dec 2, 2021
tankerkiller125
approved these changes
Dec 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our Document class does not support generating meta prev/next URLs. With this PR, content can set
pageandhasNextPageon theDocumentobject. This, in turn, will appropriately generate next/prev links, and configure the canonical URL properly.Questions for Reviewers:
As part of this, we introduce a helper function to add/override/remove params from URLs. Is this the best place for it?
As an alternative approach, we could create a generic
AbstractPaginatedContentclass with methods, and move logic into there. Then, Document would just have public fields fornextPageUrlandprevPageUrl. This would let Document focus on arrangement/presentation, and avoid hardcoding logic for a pagination scheme. On the other hand, if we have centralized, defined logic for a pagination scheme, we're less likely to run into issues.