Disallow dashes in database prefix #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a temporary fix it has been requested to disallow dashes in the database prefix. The installation process fails when the prefix does include a dash. flarum#3022
askvortsov1
approved these changes
Oct 1, 2021
askvortsov1
requested review from
dsevillamartin,
davwheat and
tankerkiller125
davwheat
approved these changes
Oct 1, 2021
|
We're currently in feature freeze for our 1.1 release, so we'll merge this in a bit. Thanks again! |
|
Wow, you're fast. I'll continue to look into the bigger issue so we can revert this change later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a temporary fix it has been requested to disallow dashes in the database prefix. The installation process fails when the prefix does include a dash.
#3022
--
*#3022
Changes proposed in this pull request:
The install process will now throw an error when the database prefix contains a dash.
Confirmed
composer test).