Add README documentation to ExtensionPage #3094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davwheat
requested changes
Oct 6, 2021
davwheat
approved these changes
Oct 6, 2021
luceos
approved these changes
Oct 6, 2021
askvortsov1
requested changes
Oct 6, 2021
There was a problem hiding this comment.
I like the frontend a lot, and think this would be a great feature. From a code organization perspective, I'm not sure that the controller directly is the best place for this implementation to live. I'm also hesitant to add new endpoints that are far from complying with the JSON:API spec if not necessary. Left some ideas in the code.
|
So @askvortsov1 and I discussed this again today. We decided to simplify things a little and not go down the whole boilerplate building excercise just yet. |
askvortsov1
requested changes
Oct 25, 2021
askvortsov1
requested changes
Oct 27, 2021
Co-authored-by: Alexander Skvortsov <38059171+askvortsov1@users.noreply.github.com>
askvortsov1
approved these changes
Oct 28, 2021
|
Thank you so much for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Adds a button to display an extensions
READMEfile within a modal directly from theExtensionPageReviewers should focus on:
This is almost a "lift and shift" from
blomstra/readme. Did I forget any core conventions when migrating this?Screenshot
Confirmed
composer test).