Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide webkit search button #3128

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Conversation

askvortsov1
Copy link
Sponsor Member

Fixes #3126

Changes proposed in this pull request:
Hide the button, as it's not standard. Add a comment so we revisit it eventually, in case more browsers add support.

Tested locally.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@askvortsov1 askvortsov1 merged commit 6200ffe into master Oct 27, 2021
@askvortsov1 askvortsov1 deleted the as/hide-duplicate-search-clear-button branch October 27, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two search form clear buttons
3 participants