Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with CSS styles when in-between whole pixel values for viewport width #3139

Merged
merged 3 commits into from
Oct 29, 2021

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Oct 29, 2021

Fixes #2915

Changes proposed in this pull request:

Fixes issue where custom UI scaling, combined with specific viewport widths, would result in a broken UI.

This will not fix extensions which use explicit media queries rather than our built-in variable-based ones.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added this to the 1.2 milestone Oct 29, 2021
@davwheat davwheat self-assigned this Oct 29, 2021
Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a comment about this? Otherwise it's quite confusing why 0.02 exactly.

@davwheat
Copy link
Member Author

Done.

@davwheat davwheat merged commit a1b5ef5 into master Oct 29, 2021
@davwheat davwheat deleted the dw/fix-uncommon-ui-bug branch October 29, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media query breakpoints conflict with Windows display scaling
3 participants