Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a11y): show post action items when focus is within the post #3173

Merged
merged 2 commits into from
Nov 21, 2021

Conversation

davwheat
Copy link
Member

Changes proposed in this pull request:

Shows post action items when the currently focused element is within the parent .Post.

Previously, tabbing through Flarum would result in focus being "lost" on the screen, since the post actions were invisible, even when focused. This prevents this issue.

Reviewers should focus on:

I considered only checking is focus was within the .Post-actions section, but decided that showing the actions whenever an element within the post is focused would closer match the existing hover-based functionality.

Screenshot

image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added type/bug type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) labels Nov 21, 2021
@davwheat davwheat added this to the 1.2 milestone Nov 21, 2021
@davwheat davwheat self-assigned this Nov 21, 2021
@davwheat davwheat merged commit bb817d9 into master Nov 21, 2021
@davwheat davwheat deleted the dw/show-actions-when-focused branch November 21, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants