fix(a11y): show post action items when focus is within the post #3173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Shows post action items when the currently focused element is within the parent
.Post
.Previously, tabbing through Flarum would result in focus being "lost" on the screen, since the post actions were invisible, even when focused. This prevents this issue.
Reviewers should focus on:
I considered only checking is focus was within the
.Post-actions
section, but decided that showing the actions whenever an element within the post is focused would closer match the existing hover-based functionality.Screenshot
Necessity
Confirmed
composer test
).