Convert routes to Typescript #3177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js/src/forum/ForumApplication.ts
Outdated
| constructor() { | ||
| super(); | ||
|
|
||
| routes(this); | ||
|
|
||
| this.route = Object.assign(Application.prototype.route.bind(this), makeRouteHelpers(this)); |
There was a problem hiding this comment.
We may want to use this.constructor.route instead? That way we don't make it specific to Application in case for some reason some extension wants to modify it. Even if not for that, just to make sure we're referencing the current subclass just in case.
There was a problem hiding this comment.
That exact syntax didn't work, but I changed it to use prototypes
SychO9
approved these changes
Dec 1, 2021
davwheat
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts
routes.jsfiles to Typescript, resolves issues withapp.route.Xnot found.