Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve avatar upload experience #3181

Merged
merged 4 commits into from
Dec 1, 2021
Merged

Improve avatar upload experience #3181

merged 4 commits into from
Dec 1, 2021

Commits on Nov 25, 2021

  1. Improve avatar upload experience 

    Fixes #3055

- On the frontend, accept only image types as a hint to the OS file picker
- On the backend, use `getimagesize` as an additional validation guard against non-image files with image extensions. This isn't necessary for security, but results in less confusing error mesages.
    @askvortsov1
    askvortsov1 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    720f7dd View commit details
    Browse the repository at this point in the history

  2. Apply fixes from StyleCI 

    [ci skip] [skip ci]
    @askvortsov1 @StyleCIBot
    askvortsov1 authored and StyleCIBot committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    56fcbb6 View commit details
    Browse the repository at this point in the history

  3. Try compiling image as part of validation

    @askvortsov1
    askvortsov1 committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    b62d961 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2021

  1. Restore mime-based avatar validation, raise image error for image mak… 

    …e errors.
    @askvortsov1
    askvortsov1 committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    ad93657 View commit details
    Browse the repository at this point in the history