possibly fixes the issue with post number calculation #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip] [skip ci]
askvortsov1
requested changes
Mar 23, 2022
Fixed the major one. There's still something funky with sorting or something of the post ids... |
That doesn't matter since there's no default sort for posts in the backend.
|
Core tests seem okay now. I've not seen the Integrity constraint exception resurface on Bokt 🥳 @askvortsov1 imo this is ready for merging. |
askvortsov1
approved these changes
Mar 30, 2022
tankerkiller125
approved these changes
Mar 31, 2022
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the post number calculation causing exceptions
Integrity constraint violation: 1062 Duplicate entryas reported by @iPurpl3x and clearly visible in highly volatile communities.This fix is currently applied to a non-public Flarum instance running in sync with the production community by Bokt (@BartVB). The last error reported was a bit less than 40 minutes ago, with posts happening every second I expect this issue to recur at least a few times the coming 24 hours. If the issue occurs again this PR is invalid.
Will report back.