Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: php8.1 deprecation warnings #3384

Merged
merged 1 commit into from
Apr 19, 2022
Merged

fix: php8.1 deprecation warnings #3384

merged 1 commit into from
Apr 19, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Apr 9, 2022

Fixes #3383

Changes proposed in this pull request:

Reviewers should focus on:
Do we want to move the newly forked packages under flarum ? the packages that needed forking and updating were: axy/sourcemap axy/errors axy/codecs-base64vlq and tobscure/json-api.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

@SychO9
Copy link
Member Author

SychO9 commented Apr 9, 2022

FYI sycho/json-api was forked from v0.4.1 of tobscure/json-api while we were using v0.3.0

@davwheat
Copy link
Member

davwheat commented Apr 9, 2022

Is it worth opening PRs back to the original repos to see if maintainers would be willing to merge them instead of maintaining our own forks?

@SychO9
Copy link
Member Author

SychO9 commented Apr 9, 2022

That would be better tbh, I didn't try as axy/* packages looked abandoned. I'll give it a shot and see. Toby's package is confirmed abandoned so there's no need.

@davwheat
Copy link
Member

davwheat commented Apr 9, 2022

Is it worth investigating whether to switch to Toby's new JSON API library for 2.0?

@SychO9
Copy link
Member Author

SychO9 commented Apr 9, 2022

That's seems to be the plan actually

@SychO9 SychO9 added this to the 1.3 milestone Apr 11, 2022
@SychO9 SychO9 added the dependencies Pull requests that update a dependency file label Apr 11, 2022
@SychO9 SychO9 merged commit be2da3e into main Apr 19, 2022
@SychO9 SychO9 deleted the sm/php-8.1 branch April 19, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PHP 8.1
4 participants