Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nickname regex validation not working #3430

Merged
merged 3 commits into from
May 20, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented May 19, 2022

Fixes #3416

Changes proposed in this pull request:
The validator doesn't call the failure callback which allows rejecting non-conforming inputs.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@SychO9 SychO9 added this to the 1.4 milestone May 19, 2022
@SychO9 SychO9 removed this from the 1.4 milestone May 20, 2022
@SychO9 SychO9 merged commit 89b1940 into main May 20, 2022
@SychO9 SychO9 deleted the sm/3416-fix-regex-use-in-nicknames branch May 20, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nicknames Extension Regexp Not Working as Expected
3 participants