Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: settings extender working only with first instances #3439

Merged
merged 2 commits into from
May 24, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented May 23, 2022

Fixes #3438

Changes proposed in this pull request:
This was an oversight, after extending the container binding it wasn't returned.
The extender still worked, but only partially, it didn't register all defaults. I'm not entirely sure yet how that even worked before.
I have tweaked the tests to catch this.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 requested a review from imorland May 23, 2022 23:03
@imorland
Copy link
Member

Confirmed working! Thank you @SychO9

@SychO9 SychO9 merged commit eb4bac3 into main May 24, 2022
@SychO9 SychO9 deleted the sm/3438-fix-settings-extender branch May 24, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default settings values are not returned
3 participants