New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(suspend): suspension modal shows after suspension is over #3449

Merged

SychO9 merged 1 commit into main from sm/3441-suspension-modal-should-expire

Jun 19, 2022

Member

SychO9 commented Jun 3, 2022 •

edited

Loading

Fixes #3441

Changes proposed in this pull request:
Checks on the frontend that suspendedUntil time has passed before showing the modal to the user.

Necessity

Has the problem that is being solved here been clearly explained?
If applicable, have various options for solving this problem been considered?
For core PRs, does this need to be in core, or could it be in an extension?
Are we willing to maintain this for years / potentially forever?

Confirmed

Frontend changes: tested on a local Flarum installation.
Backend changes: tests are green (run composer test).
Core developer confirmed locally this works as intended.
Tests have been added, or are not appropriate here.


          fix(suspend): suspension modal shows after suspension is over

699cb33

davwheat approved these changes

View reviewed changes

SychO9 self-assigned this

SychO9 merged commit 74bcab8 into main

SychO9 deleted the sm/3441-suspension-modal-should-expire branch

June 19, 2022 22:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet