Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support custom reusable setting components for buildSettingComponent #3494

Merged
merged 3 commits into from
Jun 20, 2022

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Jun 20, 2022

Changes proposed in this pull request:

Adds the ability for extensions to declare custom setting components for use with buildSettingComponent.

This could be used to aid model selection, for example, such as providing an easy and reusable way to allow extensions to interact with each other through their settings pages.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

@davwheat davwheat merged commit 293e8ab into main Jun 20, 2022
@davwheat davwheat deleted the dw/custom-adminpage-setting-components branch June 20, 2022 12:01
@SychO9 SychO9 added this to the 1.4 milestone Jun 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants