Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: forum/discussion titles in notifications overflow #3500

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

dsevillamartin
Copy link
Member

Fixes #3408

Changes proposed in this pull request:

  • Apply overflow & ellipsis to span as well as parent element
    • The span appears when the title is a discussion title, as it separates discussion badges vs titles in the DOM

Reviewers should focus on:
Do we just want to wrap the forum title in a span?

Screenshot
image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added this to the 1.4 milestone Jul 4, 2022
@davwheat davwheat merged commit 709c556 into main Jul 4, 2022
@davwheat davwheat deleted the ds/3408-truncate-notification-header-titles branch July 4, 2022 11:17
@davwheat davwheat self-assigned this Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification title length
2 participants