Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: composer title positioning incorrect with custom header height #3502

Merged
merged 1 commit into from
Jul 4, 2022

Conversation

davwheat
Copy link
Member

@davwheat davwheat commented Jul 4, 2022

Changes proposed in this pull request:

With a custom header height specified, the mobile composer slips up, with some elements appearing behind the header as if it isn't bigger, and the title isn't centred correctly.

This PR fixes both of these issues, as seen in the screenshots below.

Reviewers should focus on:

N/A

Screenshot

Before and after screenshots:
image
image

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added this to the 1.4 milestone Jul 4, 2022
@davwheat davwheat requested review from luceos and SychO9 July 4, 2022 11:15
@davwheat davwheat self-assigned this Jul 4, 2022
@davwheat davwheat merged commit 7cd2871 into main Jul 4, 2022
@davwheat davwheat deleted the dw/header-height-composer branch July 4, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants