Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: global logout to clear all sessions, access tokens, email tokens and password tokens #3605

Merged
merged 10 commits into from
Feb 21, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Aug 17, 2022

Relies on #3587

Changes proposed in this pull request:

  • Adds a forum controller that clears the current session and all access tokens, email tokens, and password tokens.
  • Adds a security button to link to the security page in the session dropdown.

Screenshot
Screenshot from 2022-08-17 11-12-41

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9 SychO9 self-assigned this Aug 17, 2022
@SychO9 SychO9 added this to the 1.x milestone Aug 17, 2022
Copy link
Member

@davwheat davwheat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THIS IS AMAZING THANK YOU SO MUCH

framework/core/js/src/forum/components/SecurityPage.tsx Outdated Show resolved Hide resolved
@luceos
Copy link
Member

luceos commented Aug 23, 2022

I wouldn't want to sacrifice an entry in the session dropdown now, the entry on the user settings page imo suffices. Screen space is limited as is, especially on mobile. Thoughts?

@davwheat
Copy link
Member

Hmmm that's a good point. I think having it under settings on its own should be fine.

@SychO9
Copy link
Member Author

SychO9 commented Aug 23, 2022

That's fine by me

Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good button 👍

Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, needs rebase

@SychO9 SychO9 modified the milestones: 1.x, 1.6 Sep 6, 2022
@SychO9
Copy link
Member Author

SychO9 commented Oct 11, 2022

Since this relies on #3587 we'll merge when that's done.

@SychO9 SychO9 modified the milestones: 1.6, 1.7 Nov 15, 2022
@SychO9 SychO9 requested a review from a team as a code owner November 21, 2022 17:25
Base automatically changed from sm/access-tokens-ui to main February 21, 2023 13:14
@SychO9 SychO9 changed the title feat: add global logout to clear all sessions, access tokens, email tokens and password tokens feat: global logout to clear all sessions, access tokens, email tokens and password tokens Feb 21, 2023
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
SychO9 and others added 2 commits February 21, 2023 15:18
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 merged commit bbf8734 into main Feb 21, 2023
@SychO9 SychO9 deleted the sm/global-logout branch February 21, 2023 14:28
@luceos luceos mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: completed
Development

Successfully merging this pull request may close these issues.

5 participants