Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing states exports to compat.ts #3683

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Add missing states exports to compat.ts #3683

merged 1 commit into from
Nov 17, 2022

Conversation

iPurpl3x
Copy link
Contributor

Changes proposed in this pull request:
Add missing states exports to compat.ts

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Core developer confirmed locally this works as intended.

@iPurpl3x iPurpl3x requested a review from a team as a code owner November 17, 2022 08:36
@imorland imorland added this to the 1.7 milestone Nov 17, 2022
@davwheat davwheat merged commit 3612342 into flarum:main Nov 17, 2022
@SychO9 SychO9 added the javascript Pull requests that update Javascript code label Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

@imorland imorland imorland approved these changes

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code type/extensibility
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
4 participants
@iPurpl3x @davwheat @imorland @SychO9