fix: evaluated page title content #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
clarkwinkelmann
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
As mentioned on Discord I don't really like the use of innerHTML since its behavior on <title> isn't precisely described in the official web spec, but I'm hopeful we will be able to drop it in a future release once #3685 is fixed.
I have not tested this specific PR but I played around with the same changes on my dev-main install and the changes proposed work well in my local tests.
davwheat
requested changes
Nov 18, 2022
Co-authored-by: David Wheatley <hi@davwheat.dev>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
davwheat
approved these changes
Nov 18, 2022
imorland
approved these changes
Nov 18, 2022
SychO9
added a commit
that referenced
this pull request
Nov 18, 2022
* fix: evaluated page title content * chore: add comment * chore: use DOMParser instead * fix: use `innerHTML` for the actual value Signed-off-by: Sami Mazouz <sychocouldy@gmail.com> Co-authored-by: David Wheatley <hi@davwheat.dev>
SychO9
added a commit
that referenced
this pull request
Nov 18, 2022
* fix: evaluated page title content * chore: add comment * chore: use DOMParser instead * fix: use `innerHTML` for the actual value Signed-off-by: Sami Mazouz <sychocouldy@gmail.com> Co-authored-by: David Wheatley <hi@davwheat.dev>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Properly escapes HTML entities when setting page titles. Otherwise, any decoded title content is evaluated as HTML code.
Necessity
Confirmed
composer test).