Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow push additional items to the end of the poststream #3691

Merged
merged 4 commits into from
Nov 25, 2022

Conversation

imorland
Copy link
Member

Fixes #0000

Changes proposed in this pull request:
Adds an opportunity for extensions to add additional components via an ItemList at the end of the PostStream

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@imorland imorland requested a review from a team as a code owner November 22, 2022 11:37
@imorland imorland added this to the 1.7 milestone Nov 22, 2022
Co-authored-by: David Wheatley <hi@davwheat.dev>
@SychO9 SychO9 added the javascript Pull requests that update Javascript code label Nov 25, 2022
@imorland imorland merged commit 6f4f964 into main Nov 25, 2022
@imorland imorland deleted the im/poststream branch November 25, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code type/extensibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants