Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Admin User Search #3712

Merged
merged 6 commits into from
Jan 13, 2023
Merged

feat: Admin User Search #3712

merged 6 commits into from
Jan 13, 2023

Conversation

OrdinaryJellyfish
Copy link
Contributor

Fixes #3711

Changes proposed in this pull request:

  • Adds search input to admin users list

Reviewers should focus on:

  • If the search input works as intended

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@OrdinaryJellyfish OrdinaryJellyfish requested a review from a team as a code owner December 17, 2022 22:16
@OrdinaryJellyfish OrdinaryJellyfish changed the title Admin User Search feat: Admin User Search Dec 17, 2022
SychO9
SychO9 reviewed Dec 18, 2022
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Some comments

framework/core/js/src/admin/components/UserListPage.tsx Outdated Show resolved Hide resolved
framework/core/js/src/admin/components/UserListPage.tsx Outdated Show resolved Hide resolved
framework/core/js/src/admin/components/UserListPage.tsx Outdated Show resolved Hide resolved
framework/core/locale/core.yml Outdated Show resolved Hide resolved
SychO9
SychO9 approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@SychO9 SychO9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Design-wise I think the entire page could be improved, especially once we add in more features, but that can be done at a later time.

luceos
luceos approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@luceos luceos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @OrdinaryJellyfish 👍

@SychO9 feel free to merge.

@SychO9 SychO9 merged commit 20e7d24 into main Jan 13, 2023
@SychO9 SychO9 deleted the tk/3711-admin-user-search branch January 13, 2023 08:31
@davwheat davwheat modified the milestone: 1.7 Feb 23, 2023
@luceos luceos mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luceos luceos luceos approved these changes

@SychO9 SychO9 SychO9 approved these changes

@davwheat davwheat Awaiting requested review from davwheat

@imorland imorland Awaiting requested review from imorland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin user search
4 participants
@OrdinaryJellyfish @luceos @SychO9 @davwheat