Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: permissions table on mobile is unusable #3722

Merged
merged 3 commits into from
Jan 14, 2023
Merged

fix: permissions table on mobile is unusable #3722

merged 3 commits into from
Jan 14, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Jan 14, 2023 •
edited
Loading

Fixes #3649

Changes proposed in this pull request:
Removes sticky positioning on mobile.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@SychO9
fix: permissions table on mobile is unusable
8093fa5 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner January 14, 2023 17:42
davwheat
davwheat approved these changes Jan 14, 2023
View reviewed changes
framework/core/less/admin/PermissionsPage.less Outdated Show resolved Hide resolved
SychO9 and others added 2 commits January 14, 2023 19:23
@SychO9 @davwheat
chore: unnecessary prefixed version
45262e1 
Co-authored-by: David Wheatley <hi@davwheat.dev>
@SychO9
chore: unnecessary prefixed version
6cd3f95 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 merged commit 2d2bf5c into main Jan 14, 2023
@SychO9 SychO9 deleted the sm/3649-fix-permissions-table-mobile-scroll branch January 14, 2023 18:34
@luceos luceos mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Admin dashboard on iPhone problems
2 participants
@SychO9 @davwheat