Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tags): clickable tag labels have underline #3737

Merged
merged 1 commit into from
Feb 21, 2023
Merged

fix(tags): clickable tag labels have underline #3737

merged 1 commit into from
Feb 21, 2023

Conversation

rob006
Copy link
Contributor

@rob006 rob006 commented Feb 17, 2023

Currently there is a bug where underline has incorrect color if tag is displayed inside of .EventPost:

2245dc82

This PR removes underline in this label completely, since even with fixed color it IMO looks weird.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@rob006 rob006 requested a review from a team as a code owner February 17, 2023 14:10
@rob006 rob006 changed the title Remove underline from clickable tags labels fix: remove underline from clickable tags labels Feb 17, 2023
@SychO9 SychO9 added this to the 1.7 milestone Feb 21, 2023
@SychO9 SychO9 changed the title fix: remove underline from clickable tags labels fix(tags): clickable tag labels have underline Feb 21, 2023
@SychO9 SychO9 merged commit ea7b270 into flarum:main Feb 21, 2023
@rob006 rob006 deleted the patch-1 branch February 21, 2023 13:14
@luceos luceos mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

@SychO9 SychO9 SychO9 approved these changes

Assignees
No one assigned
Labels
type/theme(ing)
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@rob006 @imorland @SychO9