Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mentions): post reply mention missing notification on approval #3738

Merged
merged 4 commits into from
Feb 21, 2023
Merged

fix(mentions): post reply mention missing notification on approval #3738

merged 4 commits into from
Feb 21, 2023

Conversation

OrdinaryJellyfish
Copy link
Contributor

@OrdinaryJellyfish OrdinaryJellyfish commented Feb 18, 2023 •
edited by SychO9
Loading

Fixes #3687

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@OrdinaryJellyfish OrdinaryJellyfish requested a review from a team as a code owner February 18, 2023 04:48
@SychO9 SychO9 changed the title fix: Reply notification on approval fix(mentions): post reply mention missing notification on approval Feb 18, 2023
@SychO9
fix: phpstan error
399451f 
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
luceos
luceos approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@luceos luceos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@imorland imorland added this to the 1.7 milestone Feb 21, 2023
@imorland imorland merged commit 33e2bd1 into main Feb 21, 2023
@imorland imorland deleted the tk/3687-notify-on-approval branch February 21, 2023 15:04
@SychO9 SychO9 removed this from the 1.7 milestone Feb 21, 2023
@luceos luceos mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luceos luceos luceos approved these changes

@imorland imorland imorland approved these changes

@SychO9 SychO9 SychO9 approved these changes

Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notifications on post approval broken
5 participants
@OrdinaryJellyfish @luceos @imorland @SychO9 @StyleCIBot