Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make go-to-page input number-like #3743

Merged
merged 1 commit into from
Feb 21, 2023
Merged

fix: make go-to-page input number-like #3743

merged 1 commit into from
Feb 21, 2023

Conversation

davwheat
Copy link
Member

Changes proposed in this pull request:

Oops.

Updates the attrs for the go-to-page input textbox using info from UK GDS.

https://technology.blog.gov.uk/2020/02/24/why-the-gov-uk-design-system-team-changed-the-input-type-for-numbers/

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@davwheat davwheat added the type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.) label Feb 21, 2023
@davwheat davwheat added this to the 1.7 milestone Feb 21, 2023
@davwheat davwheat self-assigned this Feb 21, 2023
@davwheat davwheat requested a review from a team as a code owner February 21, 2023 13:32
@davwheat davwheat changed the title chore: make go-to-page input number-like fix: make go-to-page input number-like Feb 21, 2023
@SychO9 SychO9 removed this from the 1.7 milestone Feb 21, 2023
@SychO9 SychO9 merged commit d35bb87 into main Feb 21, 2023
@SychO9 SychO9 deleted the dw/users-list/go-to-page branch February 21, 2023 14:24
@luceos luceos mentioned this pull request Mar 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SychO9 SychO9 SychO9 approved these changes

Assignees

@davwheat davwheat

Labels
type/accessibility Issues relating to accessibility (keyboard navigation, screenreaders, text contrast, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davwheat @SychO9