Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placeholders names used in 'core.forum.security.token_item_title' translation #3752

Merged
merged 1 commit into from
Mar 12, 2023

Conversation

rob006
Copy link
Contributor

@rob006 rob006 commented Mar 11, 2023

See

token_item_title: "{title} - {token}"

Without this change token title always contains only -.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

@rob006 rob006 requested a review from a team as a code owner March 11, 2023 17:41
@SychO9 SychO9 merged commit cce6b74 into flarum:main Mar 12, 2023
@SychO9 SychO9 added this to the 1.7.1 milestone Mar 12, 2023
@rob006 rob006 deleted the token-item-title branch March 12, 2023 09:43
@SychO9 SychO9 linked an issue Mar 12, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to display Developer Token.
3 participants